[PATCH v2] ARM: shmobile: kzm9g dts: Use adxl345-specific compatible property

Simon Horman horms at verge.net.au
Wed Aug 12 17:05:38 PDT 2015


On Wed, Jul 08, 2015 at 09:51:49AM +0900, Simon Horman wrote:
> On Tue, Jul 07, 2015 at 09:56:29AM +0300, Laurent Pinchart wrote:
> > Hi Simon,
> > 
> > On Tuesday 07 July 2015 09:26:21 Simon Horman wrote:
> > > On Mon, Jul 06, 2015 at 04:29:33PM +0300, Laurent Pinchart wrote:
> > > > On Monday 06 July 2015 12:55:32 Geert Uytterhoeven wrote:
> > > > > Replace the deprecated generic "adi,adxl34x" compatible value by the
> > > > > adxl345-specific "adi,adxl345" value, cfr. commit e465bf6fc55d5ce2 ("DT:
> > > > > i2c: Deprecate adi,adxl34x compatible string").
> > > > > 
> > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be>
> > > > 
> > > > Acked-by: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>
> > > > 
> > > > > ---
> > > > > Depends on commit 3a38958d2477b718 ("Input: adxl34x - add OF match
> > > > > support"), which is in v4.2-rc1.
> > > > > 
> > > > > This is v2 of "ARM: shmobile: kzm9g dts: Add adxl345-specific compatible
> > > > > property".
> > > 
> > > It appears to me that this will cause a regression when booting old kernels
> > > with new dts blobs. For that reason think we should consider v1
> > > of this change coupled with a schedule to remove use of the deprecated
> > > compat string.
> > 
> > That's the forward compatibility that Geert mentioned, is that really an 
> > issue, especially on this board ?
> 
> I think it would be best to provide backwards compatibility unless there
> is a compelling reason not to.

I would like to revisit this discussion with a view to getting some version
of this patch queued up (yes I know I pushed back on it earlier in this thread).



More information about the linux-arm-kernel mailing list