[PATCH TRIVIAL] Enable GICv2m on ARM virt machine
Marc Zyngier
marc.zyngier at arm.com
Fri Aug 7 03:33:54 PDT 2015
On 07/08/15 11:20, Pavel Fedin wrote:
> Hello!
>
>> You may want to add a comment about the dependency chain that requires
>> the generic msi.h.
>
> The error i get is:
> --- cut ---
> In file included from kernel/irq/chip.c:14:0:
> include/linux/msi.h:123:21: fatal error: asm/msi.h: No such file or directory
> #include <asm/msi.h>
> ^
> --- cut ---
>
> This portion in linux/msi.h sits under #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN, which is activated by
> the following chain:
> ARM_GIC_V2M => PCI_MSI_IRQ_DOMAIN => GENERIC_MSI_IRQ_DOMAIN
>
> Do i need to respin just because of comment?
That's for Russell to decide, really. But I feel that adding an include
file that affects the whole architecture (and not just a single
platform) deserves an explanation in the commit log.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
More information about the linux-arm-kernel
mailing list