[PATCH 2/3] nvmem: imx-ocotp: Add i.MX6 OCOTP driver

Philipp Zabel p.zabel at pengutronix.de
Thu Aug 6 09:28:10 PDT 2015


Hi Srinivas,

Am Donnerstag, den 06.08.2015, 17:20 +0100 schrieb Srinivas Kandagatla:
> Few Nits..
> 
> On 04/08/15 14:02, Philipp Zabel wrote:
> > +#include <linux/clk.h>
> May be you can drop this?

Yes, that's a left-over and can be removed.

> BTW, who is taking care of the gated peripheral clock controlled for 
> this driver?

Nobody. I had initially copied the code that actually senses the fuses,
but since this happens during power-on reset anyway (all values are
stored in shadow registers), I didn't see the point and dropped it for
now.
The shadow registers are clocked directly by the ungated ipg_root clock.

[...]
> > +MODULE_LICENSE("GPL");
> 
> GPL v2 ?

Will do.

thanks
Philipp




More information about the linux-arm-kernel mailing list