[PATCH 1/2] drivers: PL061: add support for platform driver probing

Graeme Gregory gg at slimlogic.co.uk
Mon Aug 3 08:13:31 PDT 2015



On Mon, 3 Aug 2015, at 01:40 PM, Linus Walleij wrote:
> On Mon, Aug 3, 2015 at 8:59 AM, Shannon Zhao <zhaoshenglong at huawei.com>
> wrote:
> 
> > From: Shannon Zhao <shannon.zhao at linaro.org>
> >
> > Since PL061 currently only supports AMBA driver, to support using GPIO
> > PL061 by DT or ACPI, it needs to add support for platform driver.
> > A DT binding is provided with this patch, ACPI support is added in a
> > separate one.
> >
> > Signed-off-by: Shannon Zhao <zhaoshenglong at huawei.com>
> > Signed-off-by: Shannon Zhao <shannon.zhao at linaro.org>
> 
> I already stated in 0/2 what the problem is with this, and it's obviously
> adding
> a huge codechunk, very similar to the AMBA probe path.
> 
> We need to investigate if ACPI can just spawn AMBA/PrimeCell type devices
> instead.
> 
AMBA DT support is a hideous hack, we had kind of hoped to avoid doing
that in ACPI.

If you notice ARM already updated pl011 driver to support platform
device type probing this seems to be the way to go.

Graeme



More information about the linux-arm-kernel mailing list