[PATCH] ARM: ux500: fix ux500 secondary CPU boot regression
Linus Walleij
linus.walleij at linaro.org
Mon Aug 3 00:08:39 PDT 2015
On Fri, Jul 31, 2015 at 1:03 PM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> On Fri, Jul 31, 2015 at 10:37:54AM +0200, Linus Walleij wrote:
>> + scu_desc.pfn = __phys_to_pfn(res.start);
>> + scu_desc.length = resource_size(&res);
>> + iotable_init(&scu_desc, 1);
>> + /* As in devicemaps_init() */
>> + local_flush_tlb_all();
>> + flush_cache_all();
>
> I don't like stuff moving out of the well-defined methods where it should
> be done - it makes maintanence of the arch code harder to have platforms
> going off and doing their own stuff in random other methods.
>
> IOW, setting up mappings in this way should only be in the ->map_io method.
OK I have the better fix which is a bit more invasive (fixes device tree
and deletes the while pen hold/release and headsmp.S code chunk) but
then maybe we should just apply that instead.
Yours,
Linus Walleij
More information about the linux-arm-kernel
mailing list