[PATCH v4 1/2] watchdog: NXP LPC18xx Watchdog Timer Driver

Ariel D'Alessandro ariel at vanguardiasur.com.ar
Sat Aug 1 11:35:30 PDT 2015


Hi Guenter,

El 29/07/15 a las 12:17, Guenter Roeck escibió:
> On Mon, Jul 27, 2015 at 02:04:52AM -0300, Ariel D'Alessandro wrote:
>> This commit adds support for the watchdog timer found in NXP LPC SoCs
>> family, which includes LPC18xx/LPC43xx. Other SoCs in that family may
>> share the same watchdog hardware.
>>
>> Watchdog driver registers a restart handler that will restart the system
>> by performing an incorrect feed after ensuring the watchdog is enabled in
>> reset mode.
>>
>> As watchdog cannot be disabled in hardware, driver's stop routine will
>> regularly send a keepalive ping using a timer.
>>
>> Signed-off-by: Ariel D'Alessandro <ariel at vanguardiasur.com.ar>
> 
> Hi Ariel,
> 
> Please run the patch through checkpatch --strict.
> 
> Specifically, loook out for
> 
> WARNING: quoted string split across lines
> CHECK: No space is necessary after a cast
> CHECK: Please don't use multiple blank lines
> 
> Also see additional nitpick below.
> 

OK, I'm sending patchset v5 with these modifications.



More information about the linux-arm-kernel mailing list