[PATCH] spi: sirf: replace BUG condition by error code for unsupported transfer
Barry Song
21cnbao at gmail.com
Mon Apr 27 02:22:28 PDT 2015
From: Qipan Li <Qipan.Li at csr.com>
return error for unsupported bits-per-word format, BUG() is not right
for this scenerios as we are not an ASSERT but an error handler.
Signed-off-by: Qipan Li <Qipan.Li at csr.com>
Signed-off-by: Barry Song <baohua.song at csr.com>
---
drivers/spi/spi-sirf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-sirf.c b/drivers/spi/spi-sirf.c
index f5715c9..a50ee9b 100644
--- a/drivers/spi/spi-sirf.c
+++ b/drivers/spi/spi-sirf.c
@@ -559,7 +559,8 @@ spi_sirfsoc_setup_transfer(struct spi_device *spi, struct spi_transfer *t)
sspi->tx_word = spi_sirfsoc_tx_word_u32;
break;
default:
- BUG();
+ dev_err(&spi->dev, "bpw %d not supported\n", bits_per_word);
+ return -EINVAL;
}
sspi->word_width = DIV_ROUND_UP(bits_per_word, 8);
--
1.9.1
More information about the linux-arm-kernel
mailing list