[PATCH v2 3/4] target-arm: kvm - support for single step

Peter Maydell peter.maydell at linaro.org
Tue Apr 21 06:01:50 PDT 2015


On 21 April 2015 at 13:56, Alex Bennée <alex.bennee at linaro.org> wrote:
>
> Peter Maydell <peter.maydell at linaro.org> writes:
>>>      switch (hsr_ec) {
>>> +    case HSR_EC_SOFT_STEP:
>>> +        if (cs->singlestep_enabled) {
>>> +            return true;
>>> +        } else {
>>> +            error_report("Came out of SINGLE STEP when not enabled");
>>
>> This can only happen if there's a kernel bug, right?
>
> Sure. Should we report it differently? abort() out?

Saying 'This would be a kernel bug' in a comment would do...

-- PMM



More information about the linux-arm-kernel mailing list