[RFC PATCH 1/2] tee: generic TEE subsystem

Greg Kroah-Hartman gregkh at linuxfoundation.org
Sat Apr 18 01:55:50 PDT 2015


On Fri, Apr 17, 2015 at 09:50:56AM +0200, Jens Wiklander wrote:
> +/**
> + * struct tee_cmd_data - Opaque command argument
> + * @buf_ptr:	[in] A __user pointer to a command buffer
> + * @buf_len:	[in] Length of the buffer above
> + *
> + * Opaque command data which is passed on to the specific driver. The command
> + * buffer doesn't have to reside in shared memory.
> + * Used as argument for TEE_IOC_CMD below.
> + */
> +struct tee_ioctl_cmd_data {
> +	uint64_t buf_ptr;
> +	uint64_t buf_len;
> +};

All structures that cross the user/kernel boundry must use the __
variant of variable names.  So for this one, it must be __u64.

Same for all of your ioctl structures.

thanks,

greg k-h



More information about the linux-arm-kernel mailing list