[PATCH 1/2 RESEND] ARM: prima2: move to use REGMAP APIs for rtciobrg

[Barry Song]

2015-04-15 23:37 GMT+08:00 Arnd Bergmann <arnd at arndb.de>:
> On Tuesday 14 April 2015 11:55:55 Barry Song wrote:
>> From: Guo Zeng <Guo.Zeng at csr.com>
>>
>> all devices behind rtciobrg needs a special way to access. currently they
>> are using a platform-specific API.
>> this patch moves to REGMAP, then clients can use regmap APIs to read/write.
>> for the moment, old APIs are still kept, once all clients move to regmap,
>> old APIs will be dropped.
>>
>> this patch also does minor clean for comments, authors statement.
>>
>> Signed-off-by: Guo Zeng <Guo.Zeng at csr.com>
>> Signed-off-by: Barry Song <Baohua.Song at csr.com>
>>
>
> I've finally managed to take a look at the two patches.
>
> For this one, the implementation looks ok in principle, though I wonder
> if you would be able to move the code to a more appropriate location,
> possibly drivers/bus, drivers/soc or into the rtc-sirfsoc driver.
>
> What devices specifically are abstracted by the rtciobrg?

devices behind rtc io bridge are abstracted by it. currently, the
users include rtc drivers, system power management and reset logic.
machine-level pm codes like sleep.S and pm.c are using it too.

for the moment, i feel it is better to be in mach-prima2 since it is
still involved in several machine modules.

>
>         Arnd

-barry