[PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

[Arnd Bergmann]

On Tuesday 14 April 2015 14:37:37 Greg Kroah-Hartman wrote:
> On Tue, Apr 14, 2015 at 01:33:08PM +0200, Arnd Bergmann wrote:
> > This is true, but all other drivers do the same for GENERIC_PHY at the
> > moment. If this one gets changed, we should probably apply the same
> > solution to all current users and fix them consistently.
> > 
> > We can do one of these two:
> > 
> > a) make sure that the framework has 'static inline' stubs that let you
> >    build all drivers using it when the framework itself is disabled.
> 
> Yes, please do that.
> 
> > b) change the drivers using it to 'depends on', and make GENERIC_PHY
> >    itself a hidden option without a Kconfig prompt.
> 
> Then how could GENERIC_PHY ever get set?

Right now, every driver that provides a phy uses 'select GENERIC_PHY',
and they would have to keep doing that. This is not unlike what we
do for other silent symbols like MFD_CORE, REGMAP_I2C, or PINCTRL,
and it's not as problematic as 'select' on a user-visible option,
or (worst) mixing 'select' and 'depends on'.

	Arnd