[RESEND PATCH 4.0-rc5 v19 5/6] x86/nmi: Use common printk functions

Daniel Thompson daniel.thompson at linaro.org
Wed Apr 8 05:08:32 PDT 2015


On 07/04/15 17:43, Steven Rostedt wrote:
> On Tue, 7 Apr 2015 18:37:46 +0200
> Borislav Petkov <bp at alien8.de> wrote:
>
>
>> I would simply say:
>>
>> 	err = printk_nmi_backtrace_prepare();
>> 	if (err)
>>
>> like sane kernel code does.
>>
>
> Yes, that is even the better solution.

Ok. I'll do this.

The constant on the left habit is so ingrained for me I often don't 
notice it. I agree with Steven that modern compiler warnings render it 
an obsolete habit...


Thanks.


Daniel.




More information about the linux-arm-kernel mailing list