[PATCH] pinctrl: fsl: imx: Check for 0 config register

Linus Walleij linus.walleij at linaro.org
Tue Apr 7 06:11:49 PDT 2015


On Tue, Mar 24, 2015 at 4:26 PM, Markus Pargmann <mpa at pengutronix.de> wrote:

> 0 is used in all pinfunction definitions when a config register is not
> available, for example imx25-pinfunc.h. If a configuration value is used
> for such a pinfunction the driver will always write it to the
> configuration register if it is not -1. For a 0 configuration register
> the configuration value is written to offset 0x0. This can lead to a
> crashing/hanging system without any warning message.
>
> This patch checks for 0 config register and sets the internal value to
> -1. If the configuration value is not NO_PADCTL this leads to an error
> message that applying the configuration failed.
>
> Signed-off-by: Markus Pargmann <mpa at pengutronix.de>

Patch applied with the ACKs and all.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list