[PATCHv6] media: i2c/adp1653: Documentation for devicetree support for adp1653

Sakari Ailus sakari.ailus at iki.fi
Fri Apr 3 14:39:33 PDT 2015


On Fri, Apr 03, 2015 at 10:26:24PM +0200, Pavel Machek wrote:
> > > +  - power-gpios: Reference to the GPIO that controls the power for the chip.
> > 
> > You're using power-gpios in documentation only.
> 
> Which is ok, because generic code adds "-gpios" itself.

Do you think you need this part:

+       if (!of_find_property(node, "gpios", NULL)) {                           
+               dev_err(&client->dev, "No gpio node\n");                        
+               return -EINVAL;                                                 
+       }                                                                       


-- 
Sakari Ailus
e-mail: sakari.ailus at iki.fi	XMPP: sailus at retiisi.org.uk



More information about the linux-arm-kernel mailing list