[PATCH] ARM: mvebu: use 0xf1000000 as internal registers on Armada 370 DB

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Apr 2 08:02:53 PDT 2015


Dear Russell King - ARM Linux,

On Thu, 2 Apr 2015 15:48:24 +0100, Russell King - ARM Linux wrote:

> Wrong.  It's Arnd's responsibility to make sure that platform maintainers
> don't do stupid things like change the DT in incompatible ways which
> break lots of people's setups.
> 
> However, it is _your_ responsibility as the platform maintainer to place

I am _not_ a platform maintainer. But thanks for supposing so :-)

> sufficient information into the commit message that explains why the
> change is necessary, and justifies the change.  Much of what you've said
> in these follow-on emails should have been in the original message to
> explain what the situation is, and why the change is appropriate.
> 
> I'm willing to bet that if the commit description had explained it
> properly, Arnd would have applied it by now.

Agreed that the commit message could have been better. Though the
commit message is sufficiently clear for the platform maintainers to
understand, since they have all the background about the platform
needed to understand it. I don't think all commit messages in the
kernel are meant to be understood by developers having no knowledge of
the area touched by the patch.

My commit log has way enough details for the platform maintainers
Andrew Lunn, Jason Cooper, Gregory Clement and Sebastian Hesselbarth to
make up their mind about the patch.

See the reaction from both Andrew and Jason: they understood the patch
and basically agree with it.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the linux-arm-kernel mailing list