[PATCH 2/2] arch: arm: samsung: Clean-up usage of CONFIG_SERIAL_SAMSUNG_UARTS symbol

Tomasz Figa tomasz.figa at gmail.com
Tue Sep 30 13:31:19 PDT 2014



On 30.09.2014 20:36, Arnd Bergmann wrote:
> On Tuesday 30 September 2014 18:10:14 Tomasz Figa wrote:
>>>> @@ -110,7 +110,7 @@ void __init s3c24xx_init_uartdevs(char *name,
>>>>                                   struct s3c24xx_uart_resources *res,
>>>>                                   struct s3c2410_uartcfg *cfg, int no)
>>>>  {
>>>> -#ifdef CONFIG_SERIAL_SAMSUNG_UARTS
>>>> +#ifdef CONFIG_SERIAL_SAMSUNG
>>>>         struct platform_device *platdev;
>>>>         struct s3c2410_uartcfg *cfgptr = uart_cfgs;
>>>>         struct s3c24xx_uart_resources *resp;
>>>
>>> Since you hardcode the number here now, you can actually drop this #ifdef.
>>
>> I believe what Abhilash did is correct, because this code is not needed
>> when there is no serial support enabled.
>>
> 
> I only added the #ifdef here because it was broken when
> CONFIG_SERIAL_SAMSUNG_UARTS was undefined.

Fair enough. This isn't really that much code to really care and most
(if not all) use cases have UART enabled anyway.

Best regards,
Tomasz



More information about the linux-arm-kernel mailing list