[PATCH v4 6/8] asm-generic/io.h: Implement generic {read, write}s*()

Max Filippov jcmvbkbc at gmail.com
Tue Sep 30 03:22:18 PDT 2014


Hi Thierry,

On Mon, Sep 29, 2014 at 12:59 PM, Thierry Reding
<thierry.reding at gmail.com> wrote:
> On Mon, Sep 29, 2014 at 10:54:34AM +0200, Geert Uytterhoeven wrote:
>> On Wed, Aug 13, 2014 at 12:28 PM, Thierry Reding
>> <thierry.reding at gmail.com> wrote:
>> > #ifndef memset_io
>> > -#define memset_io(a, b, c)     memset(__io_virt(a), (b), (c))
>> > +#define memset_io memset_io
>> > +static inline void memset_io(void __iomem *addr, int value, size_t size)
>> > +{
>> > +       memset(__io_virt(addr), value, size);
>> > +}
>> >  #endif
>>
>> xtensa/allmodconfig:
>>
>> include/asm-generic/io.h:820:2: error: implicit declaration of
>> function 'memset' [-Werror=implicit-function-declaration]
>> include/asm-generic/io.h:829:2: error: implicit declaration of
>> function 'memcpy' [-Werror=implicit-function-declaration]
>> arch/xtensa/include/asm/string.h:110:14: error: conflicting types for 'memset'
>> arch/xtensa/include/asm/string.h:113:14: error: conflicting types for 'memcpy'
>>
>> http://kisskb.ellerman.id.au/kisskb/buildresult/12028900/
>
> I think this can be fixed by including linux/string.h for memset() and
> memcpy() in include/asm-generic/io.h.

Will you send that fix or do I need to do it?

-- 
Thanks.
-- Max



More information about the linux-arm-kernel mailing list