[PATCH v1 2/4] arm: pxa: move init functions into generic.h

Arnd Bergmann arnd at arndb.de
Mon Sep 29 09:08:39 PDT 2014


On Monday 29 September 2014 08:51:46 Robert Jarzmik wrote:
> 
>  #ifdef CONFIG_PXA25x
> +#define pxa25x_handle_irq icip_handle_irq
>  extern unsigned pxa25x_get_clk_frequency_khz(int);
> +extern void __init pxa25x_init_irq(void);
> +extern void __init pxa25x_map_io(void);
> +#ifdef CONFIG_CPU_PXA26x
> +extern void __init pxa26x_init_irq(void);
> +#endif
>  #else
>  #define pxa25x_get_clk_frequency_khz(x)                (0)
>  #endif
> 

It's better to add the declarations outside of the #ifdef. I believe
the existing #ifdef is meant to provide a dummy alternative, but you
don't actually want that for the other declarations, so just add them
to a globally visible location.

	Arnd



More information about the linux-arm-kernel mailing list