[PATCH] perf tools: fix build breakage on arm and arm64 targets

Jean Pihet jean.pihet at linaro.org
Sun Sep 28 23:59:59 PDT 2014


Hi Will,

On 26 September 2014 19:19, Sudeep Holla <sudeep.holla at arm.com> wrote:
>
> On 26/09/14 18:01, Will Deacon wrote:
>>
>> Attempting to build the perf tool on arm or arm64 targets results in the
>> following failure:
>>
>> arch/arm/util/unwind-libunwind.c: In function ‘libunwind__arch_reg_id’:
>> arch/arm/util/unwind-libunwind.c:43:3: error: implicit declaration of
>> function ‘pr_err’ [-Werror=implicit-function-declaration]
>>     pr_err("unwind: invalid reg id %d\n", regnum);
>>     ^
>> This is due to commit 84f5d36f4866 ("perf tools: Move pr_* debug macros
>> into debug object") moving the pr_* macros into a new header file, but
>> failing to update architectures other than x86.
>>
>> This patch adds the missing includes, and fixes the build again.

The fix for ARM is already in the tip tree at
http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=29a3ce31c38c8f73f4e076b7ffc0876b4f5dd6c3.

Regards,
Jean

>>
>
> For ARM64, we also need the patch[1] "perf tools: Fix arm64 build error"
> which is already queued in linux-next.
>
> Regards,
> Sudeep
>
> [1] https://lkml.org/lkml/2014/6/24/1024
>



More information about the linux-arm-kernel mailing list