[PATCH 1/4] serial: mxs-auart: ctrl removed from mxs_auart_port

Russell King - ARM Linux linux at arm.linux.org.uk
Sat Sep 27 03:03:46 PDT 2014


On Sat, Sep 27, 2014 at 11:46:34AM +0200, Janusz Uzycki wrote:
> The ctrl variable duplicated mctrl, member of uart_port structure
> in serial_core.h.
> The code duplicated uart_update_mctrl() and uart_tiocmget()
> in serial_core.c.
> mxs_auart_get_mctrl() reads back RTS line. It could be removed too
> but not sure.

The only thing which the .get_mctrl method is supposed to do is to return
the state of the /input/ lines, which are CTS, DCD, DSR, RI.  The output
line state is stored in port->mctrl, and is added to the returned value
by serial_core when it's required.  RTS output state should not be
returned from the .get_mctrl method.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.



More information about the linux-arm-kernel mailing list