[PATCH 3/6] pci, thunder: Add PCIe host controller devicetree bindings

Rob Herring robherring2 at gmail.com
Fri Sep 26 11:26:09 PDT 2014


On Wed, Sep 24, 2014 at 11:06 AM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Wednesday 24 September 2014 17:37:45 Robert Richter wrote:
>>
>> +       pcie0 at 0x8480,00000000 {
>
> The name should be pci, not pci0.

And the address should be "@848000000000". There was some confusion
about when the comma should be used and it is only if you have things
like PCI bus, device, function for the addressing.


>
>> +               compatible = "cavium,thunder-pcie";

A bit too generic as many of the Cavium bindings have been.

Rob



More information about the linux-arm-kernel mailing list