[PATCH] arm, vt8500, LLVMLlinux: Use mcr instead of mcr% for mach-vt8500

Arnd Bergmann arnd at arndb.de
Wed Sep 24 02:16:24 PDT 2014

On Tuesday 23 September 2014 20:44:44 Behan Webster wrote:
> The ASM below does not compile with clang and is not the way that the mcr
> command is used in other parts of the kernel.
> arch/arm/mach-vt8500/vt8500.c:72:11: error: invalid % escape in inline assembly string
>         asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
>             ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
> There are other forms that are supported on different ARM instruction sets but
> generally the kernel just uses mcr as it is supported in all ARM instruction
> sets.

Just for confirm: both forms are actually correct and we don't need this
backported for stable, right?

> Signed-off-by: Behan Webster <behanw at converseincode.com>
> Reviewed-by: Mark Charlebois <charlebm at gmail.com>
> Acked-by: Will Deacon <will.deacon at arm.com>

Acked-by: Arnd Bergmann <arnd at arndb.de>

Tony, would you like to pick this one up and send it in a pull request
to arm-soc, or should we apply it to fixes-non-critical directly?


More information about the linux-arm-kernel mailing list