[PATCH/RFC 0/2] serial: samsung: add support for early console
alim.akhtar at gmail.com
Tue Sep 23 05:53:07 PDT 2014
On Mon, Sep 22, 2014 at 6:44 PM, Marek Szyprowski
<m.szyprowski at samsung.com> wrote:
> This patchset adds support for early console defined in device tree. As
> an example, DTS files for all Exynos4 based machines are updated with
> the correct value for common chosen/sdtout property.
> To get it fully functional additional improvements (support for
> early_ioremap) are needed in early console code.
Is these really tested?
So that mean we need to wait till __ioremap__ support available for ARM.
How to take this forward then? Here is a platform (exynos7) which
needs earlycon support for debugging some of the early core things and
ARM64 has ioremap support as well. There is no reason why we should
hold earlycon support for exyons7.
I see two solution here:
1> How about re-spin patch-1 which will just add ealrycon support for
__exynos4210__ serial type only? And rest of the types can be added as
incremental patches, as and when ioremap for ARM available.
Atleast this approch will solve exynos7 problem of not having earlycon support.
And This patch can be tested on exynos7 (I can do that).
2> Take my patch which is working and tested for exynos7 and can be
easily extended and generalized when ioremap for ARM is available.
My preference would be the the first one.
Let me know your thoughts please.
In case you are ok with 1st approach, can you please re-spin patch1
with needed changes?
> Best regards
> Marek Szyprowski
> Samsung R&D Institute Poland
> Patch summary:
> Tomasz Figa (2):
> serial: samsung: Add support for of_earlycon
> ARM: dts: exynos4: Add stdout-path properties
> arch/arm/boot/dts/exynos4210-origen.dts | 1 +
> arch/arm/boot/dts/exynos4210-smdkv310.dts | 1 +
> arch/arm/boot/dts/exynos4210-trats.dts | 1 +
> arch/arm/boot/dts/exynos4210-universal_c210.dts | 1 +
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 4 +
> arch/arm/boot/dts/exynos4412-origen.dts | 1 +
> arch/arm/boot/dts/exynos4412-smdk4412.dts | 1 +
> arch/arm/boot/dts/exynos4412-tiny4412.dts | 4 +
> arch/arm/boot/dts/exynos4412-trats2.dts | 1 +
> drivers/tty/serial/Kconfig | 1 +
> drivers/tty/serial/samsung.c | 97 +++++++++++++++++++++++++
> 11 files changed, 113 insertions(+)
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
More information about the linux-arm-kernel