[PATCH V3 3/3] mfd: palmas: Add support for optional wakeup
tony at atomide.com
Fri Sep 19 12:16:49 PDT 2014
* Thomas Gleixner <tglx at linutronix.de> [140919 10:37]:
> On Fri, 19 Sep 2014, Nishanth Menon wrote:
> > On 08:37-20140919, Thomas Gleixner wrote:
> > > The other omap drivers using this have the same issue ... And of
> > > course they are subtly different.
> > >
> > > The uart one handles the actual device interrupt, which is violating
> > > the general rule of possible interrupt reentrancy in the pm-runtime
> > > case if the two interrupts are affine to two different cores. Yes,
> > > it's protected by a lock and works by chance ....
> > >
> > > The mmc one issues a disable_irq_nosync() in the wakeup irq handler
> > > itself.
> > >
> > > WHY does one driver need that and the other does not? You are not even
> > > able to come up with a common scheme for OMAP. I don't want to see the
> > > mess others are going to create when this stuff becomes more used.
> > >
> > > Thanks,
> > >
> > > tglx
> > I think I understand your concern - I request Tony to comment about
> > this. I mean, I can try and hook things like uart in other drivers
> > (like https://patchwork.kernel.org/patch/4759171/ ), but w.r.t overall
> > generic usage guideline wise, I would prefer Tony to comment.
> No, the uart and that i2c thing are just wrong. Assume the following
> device irq affine to cpu0
> wakeup irq affine to cpu1
> CPU 0 CPU 1
> runtime suspend
> enable_wake(wakeup irq);
> wakeup interrupt is raised device interrupt is raised
> dev_handler(device) dev_handler(device)
> It might work due to locking, but it is nevertheless wrong. Interrupt
> handlers for devices are guaranteed not to be reentrant. And this
> brilliant stuff simply violates that guarantee. So, no. It's wrong
> even if it happens to work by chance.
Hmm yeah that's a good point indeed.
>From hardware point of view the wake-up events behave like interrupts
and could also be used as the only interrupt in some messed up cases.
That avoids all kinds of custom APIs from driver point.
The re-entrancy problem we've most likely had ever since we enabled
the PRCM interrupts, and maybe that's why I did not even consider
that part. I think before that we were calling the driver interrupt
after waking up from the PM code..
Anyways, how about the following to deal with the re-entrancy problem:
1. The wake-up interrupt handler must have a separate interrupt
handler that just calls tasklet_schedule()
2. The device interrupt handler also just calls tasklet_schedule()
3. The tasklet then does pm_runtime_get, handles the registers, and
Or would we still have a re-entrancy problem somewhere else with
More information about the linux-arm-kernel