[PATCH v4] mfd: syscon: Decouple syscon interface from platform devices

Tomasz Figa tomasz.figa at gmail.com
Fri Sep 19 10:39:54 PDT 2014


On 19.09.2014 17:11, Tomasz Figa wrote:
>> +
>> +	if (!of_device_is_available(np) ||
> 
> Wouldn't it be enough to simply call of_find_device_by_node(np) and if
> it fails then instead create a dummy device?
> 
>> +			of_node_test_and_set_flag(np, OF_POPULATED)) {

One more thing I forgot to mention, the call to
of_node_test_and_set_flag() is also wrong, because it sets the flag,
marking the device as already populated, while it isn't.

Best regards,
Tomasz



More information about the linux-arm-kernel mailing list