[PATCH] spi: davinci: request cs_gpio's from probe

Grygorii Strashko grygorii.strashko at ti.com
Mon Sep 15 06:06:42 PDT 2014


On 09/13/2014 07:28 PM, Mark Brown wrote:
> On Fri, Sep 12, 2014 at 05:54:00PM +0300, Grygorii Strashko wrote:
> 
>>   static void davinci_spi_cleanup(struct spi_device *spi)
>>   {
>> -	if (spi->cs_gpio >= 0)
>> -		gpio_free(spi->cs_gpio);
>>   }
> 
> This function is now empty so should be removed.  I've applied for now
> but please send a followup fixing this.
> 

The function davinci_spi_cleanup() will be reused by following patch
"[PATCH v3] spi: davinci: add support for adding delay between word's transmissions"
http://www.spinics.net/lists/devicetree/msg49141.html

So, in broonie/spi.git/for-next it will not be empty.

Again, I've missed description of this dependency, sorry for that.

Regards,
-grygorii




More information about the linux-arm-kernel mailing list