[PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver.
Tejun Heo
tj at kernel.org
Sun Sep 14 02:39:11 PDT 2014
Hello,
On Sun, Sep 14, 2014 at 11:36:51AM +0530, Suman Tripathi wrote:
> We can maintain same piece (IS_ERR(ctx->csr_mux)), then we can do the
> below instead of NULL ??
>
> ctx->csr_mux = res ? devm_ioremap_resource(dev, res) : ERR_PTR(-EINVAL);
Setting it to NULL on failure would probably make more sense. No need
to carry around ERR_PTR() value around.
Thanks.
--
tejun
More information about the linux-arm-kernel
mailing list