[PATCH v3 09/12] ARM: sunxi: dt: Add sample and output mmc clocks
Chen-Yu Tsai
wens at csie.org
Sat Sep 13 01:24:14 PDT 2014
On Sat, Sep 13, 2014 at 4:18 PM, Maxime Ripard
<maxime.ripard at free-electrons.com> wrote:
> On Fri, Sep 12, 2014 at 06:23:02PM +0800, Chen-Yu Tsai wrote:
>> > mmc0: mmc at 01c0f000 {
>> > compatible = "allwinner,sun4i-a10-mmc";
>> > reg = <0x01c0f000 0x1000>;
>> > - clocks = <&ahb_gates 8>, <&mmc0_clk>;
>> > - clock-names = "ahb", "mmc";
>> > + clocks = <&ahb_gates 8>,
>> > + <&mmc0_clk>,
>> > + <&mmc0_sample_clk>,
>> > + <&mmc0_output_clk>;
>> > + clock-names = "ahb",
>> > + "mmc",
>> > + "sample",
>> > + "output";
>>
>> Just a stylish nitpick. All the other resources in these files
>> are listed inline if possible, not one phandle/value per line.
>
> Look at the PIO interrupts, every USB PHY resources, etc. ;)
I guess we need some styling cleanups. :)
ChenYu
More information about the linux-arm-kernel
mailing list