[RFC PATCH] arm64:mm: delete max_mapnr init.

Ganapatrao Kulkarni gpkulkarni at gmail.com
Thu Sep 11 04:43:11 PDT 2014


Hi Will,


On Thu, Sep 11, 2014 at 4:06 PM, Will Deacon <will.deacon at arm.com> wrote:
> On Thu, Sep 11, 2014 at 10:16:13AM +0100, Ganapatrao Kulkarni wrote:
>> setting max_mapnr results in to error, if enabled with CONFIG_NUMA,
>> which i have to replace with function set_max_mapnr.
>> However this variable is not used in arm64(with default defconfig) and better to
>> delete instead.
>>
>> Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni at caviumnetworks.com>
>> ---
>>  arch/arm64/mm/init.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
>> index 5472c24..548bd01 100644
>> --- a/arch/arm64/mm/init.c
>> +++ b/arch/arm64/mm/init.c
>> @@ -256,7 +256,6 @@ static void __init free_unused_memmap(void)
>>   */
>>  void __init mem_init(void)
>>  {
>> -     max_mapnr   = pfn_to_page(max_pfn + PHYS_PFN_OFFSET) - mem_map;
>
> I think it's cleaner to call set_max_mapnr in case this grows a use in core
> code outside of pfn_valid (which we always override).
agreed, thanks for your comment.
shall i send you the patch for this?
>
> Will

thanks
ganapat



More information about the linux-arm-kernel mailing list