[PATCH] ARM: cache-l2x0: optimize aurora range operations

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Sep 11 02:13:00 PDT 2014


Arnd,

On Mon, 08 Sep 2014 22:43:32 +0200, Arnd Bergmann wrote:
> The aurora_inv_range(), aurora_clean_range() and aurora_flush_range()
> functions are highly redundant, both in source and in object code, and
> they are harder to understand than necessary.
> 
> By moving the range loop into the aurora_pa_range() function, they
> become trivial wrappers, and the object code start looking like what
> one would expect for an optimal implementation.
> 
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
> ---
>  arch/arm/mm/cache-l2x0.c | 67 +++++++++++++++++-----------------------------------------
>  1 file changed, 22 insertions(+), 45 deletions(-)

Reviewed-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>

Note that I also did some running testing on Armada 370 and Armada XP
of both of your patches, and it worked. But since I still have concerns
on the other patch, I'm not giving a formal Tested-by yet.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the linux-arm-kernel mailing list