[PATCH 00/11] ARM: shmobile: r8a7740/armadillo legacy prototype pm domain support

Simon Horman horms at verge.net.au
Wed Sep 10 17:22:42 PDT 2014


On Tue, Sep 09, 2014 at 11:48:23AM +0200, Geert Uytterhoeven wrote:
> Hi Simon, Magnus,
> 
> On Tue, Sep 9, 2014 at 4:26 AM, Simon Horman <horms at verge.net.au> wrote:
> > I would like Magnus's opinion but mine is that the non-WIP patches
> > could be queued up. At least patch 1 and 2. Possibly others if
> > they don't depend (other than diff noise) on WIP patches.
> 
> The legacy platforms are meant to be extinct in the near future, but
> Armadillo-legacy already has some PM domain support, so adding a
> little bit more can't hurt much, IMHO.
> 
> Besides diff noise, there should not be any dependencies on WIP patches.
> 
> > With the WIP patches, I am not entirely opposed to merging them
> > too, so long as they move things in a good direction. And in particular
> > don't break anything.
> 
> "[PATCH 03/11] [WIP] ARM: shmobile: armadillo800eva legacy: Add
> missing A3SP pm domain devices" should be OK, as this turned out to be
> intended behavior.
> 
> "[PATCH 10/11] [WIP] ARM: shmobile: r8a7740: Add A4SU pm domain
>  support" probably introduces a regression for USB, as the domain is now
> powered down after boot-up. I haven't tried USB on Armadillo yet, though.
> So don't apply this one.
> 
> "[PATCH 11/11] [WIP] ARM: shmobile: r8a7740: Add A3SM pm domain
>  support" should be safe.
> 
> I would not apply the other WIP patches that add C99-commented-out code.
> These issues must be fixed for DT as well.

Thanks Geert, that all sounds reasonable to me.
I will confer with Magnus.



More information about the linux-arm-kernel mailing list