[Patch v2 RfT] ARM: Kirkwood: Fix DT based DSA.

Andrew Lunn andrew at lunn.ch
Wed Sep 10 07:08:48 PDT 2014

On Tue, Sep 09, 2014 at 01:17:42PM -0400, Jason Cooper wrote:
> > I've tested v2 of the patch and it worked fine.

Hi Eugene, thanks for testing.
> Ok, I'll consider that a Tested-by...
> > Though, I had a couple of comments:
> > 
> > 1) I have concerns regarding naming of the boards.
> > Since distros use those names to identify boards, we should use
> > shorter and consistent naming.

I agree with Jason here. The filenames don't matter, its the
description in the compatible string which people should be looking
at. And it seems Marvell own naming of these boards is not
particularly good either.

> > other too).  With 3.17rc2 I am not able to get more then ~50Mbps while
> > same board with in same setup running v3.2 or v3.10 easily pass
> > 650Mbps mark.
> Is this with/without this particular patch?  Or is this a separate
> issue?

I've not looked at this yet, but i guess it is related to TSO and the
stack trace we are seeing. It is independent of this patch. Without
this patch, networking is totally borked. With this patch, it somewhat
works, but i guess with packet loss, causing the low TCP bandwidth.

Once i'm back home i will take a look at this.

> Yes, which will be near the end of the window for getting this in.  I'd
> like to have everything hammered out _before_ he returns so he can Ack a
> (potentially) new version that I can apply.

If Eugene wants to produce a version with slightly modified model and
compatible strings, i can Ack it during the next couple of days. I
should have internet access. If not, please take the patch as is, with
the Tested-by added.


More information about the linux-arm-kernel mailing list