[Patch v2 net-next 09/12] net: fec: change FEC alignment according to i.mx6 sx requirement

Fabio Estevam festevam at gmail.com
Wed Sep 10 06:27:51 PDT 2014


On Wed, Sep 10, 2014 at 10:22 AM, Zhi Li <lznuaa at gmail.com> wrote:
> On Wed, Sep 10, 2014 at 7:51 AM, Fabio Estevam <festevam at gmail.com> wrote:
>> On Tue, Sep 9, 2014 at 5:15 PM, Frank Li <Frank.Li at freescale.com> wrote:
>>
>>> +       fep->rx_align = 0x3;
>>> +       fep->tx_align = 0x3;
>>
>> Why do you unconditionally set it as 0x3? It was 0xf for ARM and 0x3
>> for non-ARM.
>
> Will fix it at next version.

Also, please make sure to add Russell King on Cc in the next version.
He has recently done a lot of work in this driver.



More information about the linux-arm-kernel mailing list