[PATCH v7 2/5] ARM: imx6: gpc: Add PU power domain for GPU/VPU

Ulf Hansson ulf.hansson at linaro.org
Tue Sep 9 12:01:08 PDT 2014


>> > +       is_off = IS_ENABLED(CONFIG_PM_RUNTIME);
>> > +       if (is_off)
>> > +               imx6q_pm_pu_power_off(&imx6q_pu_domain.base);
>> Could you elaborate why is_off depends on CONFIG_PM_RUNTIME? That
>> seems strange to me. :-)
>> Additionally, I think it would be better to leave the domain "on"
>> state. Wouldn't that even be required for some drivers to be able to
>> succeed probing of these devices?
> The devices in the PU power domain are Vivante GPUs and the CODA Video
> Processing Unit. These are platform devices that don't need to be active
> to enumerate before being probed. The drivers support runtime PM, so if
> CONFIG_PM_RUNTIME is enabled, it is safe to disable the PU power domain
> on boot. The drivers will probe and request for the power domain to be
> enabled via runtime PM before accessing the hardware.
> If CONFIG_PM_RUNTIME is disabled, the power domain needs to stay enabled
> at all times.

Hi Philipp,

Thanks for your reply, that certainly made it clear on what you would
like to accomplish.

Before discussing further consequences in genpd of this approach
(using IS_ENABLED(CONFIG_PM_RUNTIME)), I would be interested to see
how the runtime PM support is implemented for any of the drivers you
refer to. Do you mind pointing me to any of them?

Kind regards

More information about the linux-arm-kernel mailing list