[PATCH 5/7 v6] ARM: l2c: parse 'cache-size' and 'cache-sets' properties

Arnd Bergmann arnd at arndb.de
Mon Sep 8 05:20:21 PDT 2014


On Monday 08 September 2014 13:38:04 Linus Walleij wrote:
> +       of_property_read_u32(np, "cache-size", &size);
> +       of_property_read_u32(np, "cache-sets", &sets);
> +
> +       if (!size || !sets)
> +               return;
> +
> +       way_size = size / sets;

Going back to this one: Isn't (size / sets) the set-size rather
than the way-size?

After we discussed this on IRC, I had expected a calculation like

	set_size = size / sets;
	ways = set_size / line_size;
	way_size = size / ways;

	Arnd



More information about the linux-arm-kernel mailing list