[PATCH 2/3] gpio: zynq: Fixed broken wakeup implementation

Linus Walleij linus.walleij at linaro.org
Thu Sep 4 09:27:11 PDT 2014

On Fri, Aug 29, 2014 at 7:58 PM, Soren Brinkmann
<soren.brinkmann at xilinx.com> wrote:

> From: Ezra Savard <ezra.savard at xilinx.com>
> Use of unmask/mask in set_wake was an incorrect implementation. The new
> implementation correctly sets wakeup for the gpio chip's IRQ so the gpio chip
> will not sleep while wakeup-enabled gpio are in use.
> Signed-off-by: Ezra Savard <ezra.savard at xilinx.com>
> Reviewed-by: Soren Brinkmann <soren.brinkmann at xilinx.com>

Patch applied.

However the problems seems quite generic.

Do you see this kind of error in other GPIO drivers?

IRQchip semantics always make me nervous.

Linus Walleij

More information about the linux-arm-kernel mailing list