[RFC PATCH v2 6/7] arm: call iommu_init before of_platform_populate
Arnd Bergmann
arnd at arndb.de
Tue Sep 2 11:13:46 PDT 2014
On Tuesday 02 September 2014 18:56:26 Will Deacon wrote:
> @@ -803,9 +804,11 @@ static int __init customize_machine(void)
> if (machine_desc->init_machine)
> machine_desc->init_machine();
> #ifdef CONFIG_OF
> - else
> + else {
> + of_iommu_init();
> of_platform_populate(NULL, of_default_bus_match_table,
> NULL, NULL);
> + }
> #endif
> return 0;
> }
I think it would be better to not have this depend on the presence
of an init_machine callback. Why not move of_iommu_init() in front
of the if()? It shouldn't do anything unless we have an iommu
driver that we should be using.
Arnd
More information about the linux-arm-kernel
mailing list