[STLinux Kernel] [PATCH v11 17/19] serial: asc: Adopt readl_/writel_relaxed()

Peter Griffin peter.griffin at linaro.org
Tue Sep 2 06:42:58 PDT 2014


On Tue, 02 Sep 2014, Daniel Thompson wrote:

> The architectures where this peripheral exists (ARM and SH) have expensive
> implementations of writel(), reliant on spin locks and explicit L2 cache
> management. These architectures provide a cheaper writel_relaxed() which
> is much better suited to peripherals that do not perform DMA. The
> situation with readl()/readl_relaxed()is similar although less acute.
> 
> This driver does not use DMA and will be more power efficient and more
> robust (due to absense of spin locks during console I/O) if it uses the
> relaxed variants.
> 
> This change means the driver is no longer portable and therefore no
> longer suitable for compile testing.
> 
> Signed-off-by: Daniel Thompson <daniel.thompson at linaro.org>
> Cc: Srinivas Kandagatla <srinivas.kandagatla at gmail.com>
> Cc: Maxime Coquelin <maxime.coquelin at st.com>
> Cc: Patrice Chotard <patrice.chotard at st.com>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> Cc: Jiri Slaby <jslaby at suse.cz>
> Cc: kernel at stlinux.com
> Cc: linux-serial at vger.kernel.org

Acked-by: Peter Griffin <peter.griffin at linaro.org>




More information about the linux-arm-kernel mailing list