[PATCH] iommu/arm-smmu: Allow size of stage 1 output to max possible value for sateg 2 bypass

tirumalesh chalamarla c.tirumalesh at gmail.com
Mon Sep 1 08:18:58 PDT 2014


On Mon, Sep 1, 2014 at 8:12 AM, Will Deacon <will.deacon at arm.com> wrote:
> On Mon, Sep 01, 2014 at 02:49:58PM +0100, tirumalesh chalamarla wrote:
>> On Mon, Sep 1, 2014 at 4:42 AM, Will Deacon <will.deacon at arm.com> wrote:
>> > Assuming I understand the problem correctly, why not simply remove the
>> > truncation from the existing code (untested patch below)? Does that not
>> > work for you?
>> >
>>
>> This will not restrict stage 1 out put to VA_BITS, even for two level
>> translations. this results in non debuggable problems
>> if we configure incorrectly.  there is no harm in checking the
>> condition for nested translations, as i did in my patch.
>
> Right, but restricting stage-1 output to VA_BITS doesn't make sense;
> remember it's not the same kernel writing the stage-1 and stage-2 tables.
>

Yes, if we restrict driver by limiting either one and removing NESTED
altogether, i don't have a problem with this approach.

Regards,
Tirumalesh.

> Will



More information about the linux-arm-kernel mailing list