[RFC] arm:remove clear_thread_flag(TIF_UPROBE)
Wang, Yalin
Yalin.Wang at sonymobile.com
Fri Oct 31 00:59:37 PDT 2014
> From: Joe Perches [mailto:joe at perches.com]
> > > > @@ -591,10 +591,9 @@ do_work_pending(struct pt_regs *regs, unsigned
> int
> > > thread_flags, int syscall)
> > > > return restart;
> > > > }
> > > > syscall = 0;
> > > > - } else if (thread_flags & _TIF_UPROBE) {
> > > > - clear_thread_flag(TIF_UPROBE);
> > > > + } else if (thread_flags & _TIF_UPROBE)
> > > > uprobe_notify_resume(regs);
> > > > - } else {
> > > > + else {
> > > > clear_thread_flag(TIF_NOTIFY_RESUME);
> > > > tracehook_notify_resume(regs);
> > > > }
> > >
> > > Please keep the braces.
> >
> > mm.. could I know the reason ? :)
>
> Try read Documentation/CodingStyle
>
> Chapter 3: Placing Braces and Spaces
>
> use braces in both branches:
>
> if (condition) {
> do_this();
> do_that();
> } else {
> otherwise();
> }
>
Got it, I will resend one .
Thanks
More information about the linux-arm-kernel
mailing list