net: fec: fix regression on i.MX28 introduced by rx_copybreak support

David Miller davem at davemloft.net
Thu Oct 30 09:17:10 PDT 2014


From: Lothar Waßmann <LW at KARO-electronics.de>
Date: Thu, 30 Oct 2014 07:51:04 +0100

>> Also, I don't thnk your DIV_ROUND_UP() eliminate for the loop
>> in swap_buffer() is valid.  The whole point is that the current
>> code handles buffers which have a length which is not a multiple
>> of 4 properly, after your change it will no longer do so.
>>
> Do you really think so?

Yes, because you're rounding down so you'll miss the final
partial word (if any).



More information about the linux-arm-kernel mailing list