[PATCH 1/5] phy: sun4i: add support for USB phy0
Roman Byshko
rbyshko at gmail.com
Wed Oct 29 06:46:34 PDT 2014
Hi all,
sorry for missing Signed-offs, they will be added, of course.
>>> + /* Regulation 45 ohms */
>>> + if (phy->index == 0)
>>> + sun4i_usb_phy_write(phy, PHY_RES45_CAL_EN, 0x01, 1);
>>
>> What is this code supposed to do?
>>
>> Some define for this bit and/or a better comment would be nice.
>
> From Allwinner's sources: "Enable/Disable USB res45 Calibration"
>
> which I think refers to the internal 45 ohm termination resistors
> for the USB data lines. But I'm not an expert on USB hardware.
Same with me. I will however change the comment to make it more informative.
Thanks for your review,
Roman
More information about the linux-arm-kernel
mailing list