[PATCH v2] dma: imx-sdma: clarify firmare not found warning

[Fabio Estevam]

On Mon, Jan 20, 2014 at 8:07 AM, Sascha Hauer <s.hauer at pengutronix.de> wrote:
> When a firmware cannot be found for the SDMA engine then we can
> continue with the inernal ROM firmware.
>
> The meaning of this message is frequently asked for, so make clear
> that the driver still works with the internal ROM firmware and reduce
> the loglevel from err to info.
>
> Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> Cc: Vinod Koul <vinod.koul at intel.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: Shawn Guo <shawn.guo at linaro.org>
> ---
>
> changes since v1:
> - instead of removing the message make it more clear

I know this has been posted a long time ago and agree that it would be
useful to change this dev_err code into dev_info:

Reviewed-by: Fabio Estevam <fabio.estevam at freescale.com>

>
>  drivers/dma/imx-sdma.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index c75679d..d79eaad 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1259,7 +1259,10 @@ static void sdma_load_firmware(const struct firmware *fw, void *context)
>         unsigned short *ram_code;
>
>         if (!fw) {
> -               dev_err(sdma->dev, "firmware not found\n");
> +               dev_info(sdma->dev, "external firmware not found, using ROM firmware\n");
> +               /*
> +                * In this case we just use the ROM firmware.
> +                */
>                 return;
>         }
>
> --
> 1.8.5.2