[PATCH 5/5] ARM: dts: Add dts files for Exynos4415 SoC

Daniel Drake drake at endlessm.com
Fri Oct 24 06:44:21 PDT 2014


On Fri, Oct 24, 2014 at 7:34 AM, Marek Szyprowski
<m.szyprowski at samsung.com> wrote:
> Well, I also thought about such approach, but there are some fundamental
> differences:
> interrupt and clock controllers are completely different. Using a common
> exynos4.dtsi
> and overriding them in every node will result in a code, which is a bit hard
> to follow.
> IMHO with such differences justifies using separate base dtsi file.

For the things that aren't in common, they are already split out into
soc-specific files for the existing Exynos4 variants. Taking your
example of the CMU, it already differs in different exynos4 versions
therefore is not listed in exynos4.dtsi at all.

So this argument only seems valid if the differences are really huge,
or if you are also saying the existing exynos4 dts files are bad?
Personally I have come to like the current layout, although would
definitely appreciate the reference-based syntax mentioned by Tomasz,
and this seems like a good opportunity to at least fix up exynos4.dtsi
for that.

Daniel



More information about the linux-arm-kernel mailing list