[PATCHv3 1/2] ARM: dts: socfpga: Fix SD card detect

[Doug Anderson]

Dinh,

(without the HTML mail this time, sorry)

On Tue, Oct 21, 2014 at 11:48 AM, Dinh Nguyen
<dinguyen at opensource.altera.com> wrote:
> On 10/21/2014 12:10 PM, Steffen Trumtrar wrote:
>> Hi!
>>
>> On Tue, Oct 21, 2014 at 11:15:10AM -0500, dinguyen at opensource.altera.com wrote:
>>> From: Dinh Nguyen <dinguyen at opensource.altera.com>
>>>
>>> Without this patch, the booting the SOCFPGA platform would hang at the
>>> SDMMC driver loading. The issue, debugged by Doug Anderson, turned out
>>> to be that the GPIO bank used by the SD card-detect was not set to
>>> status="okay".
>>>
>>> Suggested-by: Doug Anderson <dianders at chromium.org>
>>> Signed-off-by: Dinh Nguyen <dinguyen at opensource.altera.com>
>>> ---
>>> v3: Correctly degugged the issue to be a gpio node not having status="okay"
>>> ---
>>>  arch/arm/boot/dts/socfpga_cyclone5_socdk.dts | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts
>>> index d7296a5..03a3745 100644
>>> --- a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts
>>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts
>>> @@ -37,6 +37,12 @@
>>>               */
>>>              ethernet0 = &gmac1;
>>>      };
>>> +
>>> +    soc {
>>> +            gpio at ff709000 {
>>> +                    status = "okay";
>>> +            };
>>> +    };

I haven't dug into the details you provided about the GPIO
infrastructure of socfpga, but it does seem like it might be nice to
some easier way to reference things in
"arch/arm/boot/dts/socfpga.dtsi".

Looking at other examples they call the "gpio at ff708000" "gpio0" and
the sub node something like "porta".  Given that this is the only
reference to the GPIO, it seems like now would be the time to change
it.

-Doug