[PATCHv2 1/2] ARM: dts: socfpga: Fix SD card detect

Doug Anderson dianders at chromium.org
Mon Oct 20 08:46:56 PDT 2014


Dinh,

On Mon, Oct 20, 2014 at 8:31 AM,  <dinguyen at opensource.altera.com> wrote:
> From: Dinh Nguyen <dinguyen at opensource.altera.com>
>
> Without this patch, the booting the SOCFPGA platform would hang at the
> SDMMC driver loading. There were 2 patches that caused this to happen:
>
> - Patch 9795a846e10 "mmc: dw_mmc: remove dw_mci_of_cd_gpio/wp_gpio()" removed
>   looking for "cd-gpios", since mmc_of_parse was getting called.
> - Patch 3cf890fc42b "mmc: dw_mmc: Pass back errors from mmc_of_parse()" would
>   hang the system at the SDMMC driver loading.
>
> This patch will fix booting with SDMMC enabled on SOCFPGA dev kit.
>
> Signed-off-by: Dinh Nguyen <dinguyen at opensource.altera.com>
> ---
>  arch/arm/boot/dts/socfpga_cyclone5_socdk.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts
> index d7296a5..739c3b7 100644
> --- a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts
> +++ b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts
> @@ -69,7 +69,7 @@
>  };
>
>  &mmc0 {
> -       cd-gpios = <&gpio1 18 0>;
> +       cd = <&gpio1 18 0>;

This doesn't look right to me.  What was the error that was passed back?

I think your change has the same net effect as just deleting the
"cd-gpios" line.  ...or is there some code somewhere that is parsing
the "cd" property.



More information about the linux-arm-kernel mailing list