[PATCH] ARM: sunxi_defconfig: enable CONFIG_REGULATOR

Olof Johansson olof at lixom.net
Sun Oct 19 14:24:41 PDT 2014


On Thu, Oct 16, 2014 at 4:46 AM, Maxime Ripard
<maxime.ripard at free-electrons.com> wrote:
> On Thu, Oct 16, 2014 at 12:47:17PM +0200, Beniamino Galvani wrote:
>> On Thu, Oct 16, 2014 at 10:04:48AM +0200, Maxime Ripard wrote:
>> > Hi Olof,
>> >
>> > On Tue, Oct 14, 2014 at 11:29:09PM -0700, Olof Johansson wrote:
>> > > Commit 97a13e5289ba ('net: phy: mdio-sun4i: don't select REGULATOR') removed
>> > > the select of REGULATOR, which means that it now has to be explicitly
>> > > enabled in the defconfig or things won't work very well.
>> > >
>> > > In particular, this fixes a problem with SD/MMC not probing on my A31-based
>> > > board.
>> > >
>> > > Cc: Beniamino Galvani <b.galvani at gmail.com>
>> > > Signed-off-by: Olof Johansson <olof at lixom.net>
>> > > ---
>> > >
>> > > Maxime, I'll apply this on our fixes branch directly.
>> >
>> > I've been chasing the same bug, but didn't make a patch yet. Thanks
>> > for taking the time to do it!
>> >
>> > If it's not applied yet, you have my
>> > Acked-by: Maxime Ripard <maxime.ripard at free-electrons.com>
>>
>> Sorry for the breakage, I didn't realize that some configurations
>> could rely on the implicit selection of the symbol.
>
> Don't worry, it's fine, it's why we have a bugfix period and boots
> testing for :)

Yep, no worries.

However, it doesn't seem to have been enough and I don't know how I
made the test pass the first time when I checked the fix.  Looks like
it needs REGULATOR_FIXED_VOLTAGE too, and I didn't catch it before I
sent out the pull request. D'oh.

I'll fix it for -rc2.


-Olof



More information about the linux-arm-kernel mailing list