Chris, On Wed, Oct 15, 2014 at 1:47 PM, <zyw at rock-chips.com> wrote: > +static const struct platform_suspend_ops rk3288_suspend_ops = { > + .enter = rk3288_suspend_enter, > + .valid = suspend_valid_only_mem, > +}; As per offline discussion, let's add the regulator calls in prepare / finish.