[PATCH v2 1/4] arm: pxa: add device-tree irq init for pxa27x

Robert Jarzmik robert.jarzmik at free.fr
Mon Oct 13 11:18:05 PDT 2014


Mark Rutland <mark.rutland at arm.com> writes:

> On Sun, Oct 12, 2014 at 04:28:48PM +0100, Robert Jarzmik wrote:
>> Add the initializer for irqs in a device-tree machine on a pxa27x.
>> 
>> Signed-off-by: Robert Jarzmik <robert.jarzmik at free.fr>
>> ---
>>  arch/arm/mach-pxa/pxa27x.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>> diff --git a/arch/arm/mach-pxa/pxa27x.c b/arch/arm/mach-pxa/pxa27x.c
>> index b040d7d..8ca62e2 100644
>> --- a/arch/arm/mach-pxa/pxa27x.c
>> +++ b/arch/arm/mach-pxa/pxa27x.c
>> @@ -398,6 +398,11 @@ void __init pxa27x_init_irq(void)
>>  	pxa_init_irq(34, pxa27x_set_wake);
>>  }
>>  
>> +void __init pxa27x_dt_init_irq(void)
>> +{
>> +	pxa_dt_irq_init(pxa27x_set_wake);
>> +}
>
> Should this also add a user of this function?
Well, patches 1, 2, 3 are preparing patch 4.
And patch 4 is adding the user of this function.

I could meld this in patch 4, but it looks cleaner for me to split the function
creation, and pxa27x dt support in 2 distinct patches.

Cheers

--
Robert



More information about the linux-arm-kernel mailing list