[PATCH v3 2/3] ARM: shmobile: koelsch: enable HS-USB

Sergei Shtylyov sergei.shtylyov at cogentembedded.com
Wed Oct 8 11:11:59 PDT 2014


On 10/08/2014 10:08 PM, Felipe Balbi wrote:

>>>> From: Yoshihiro Shimoda <yoshihiro.shimoda.uh at renesas.com>

>>>> Enable HS-USB device for the Koelsch board, defining the GPIO that the driver
>>>> should check when probing (which is the ID output from MAX3355 OTG chip).

>>>> Note that there will be pinctrl-related error messages if both internal PCI
>>>> and HS-USB drivers are enabled but they should be just ignored.

>>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh at renesas.com>
>>>> [Sergei: added pin function/group and prop, moved device node, fixed summary,
>>>> added changelog]
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov at cogentembedded.com>

>>>> ---
>>>> Changes in version 3:
>>>> - added pinctrl-related properties;

>>> did you miss pinctrl here ?

>>      No, AFAICS. Or what do you mean?

> usb0_pins doesn't appear to be defined anywhere.

    They are defined in the same file, just not in this patch. If you're 
looking at some of the USB trees or Linus' tree, the corresponding patch just 
hasn't hit them yet, it's in renesas.git ATM.

WBR, Sergei




More information about the linux-arm-kernel mailing list